Een hart voor de Drupal Community

Sven Decabooter added a comment on drupal.org: Support OOP hooks

Sven Decabooter added a comment on drupal.org: Support OOP hooks

Sven Decabooter added a comment on drupal.org: Add Gitlab CI integration

svendecabooter created an issue. See original summary.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Sven Decabooter added a comment on drupal.org: Invalid json in modules/contrib/facets_range_input/composer.json

Sven Decabooter added a comment on drupal.org: Replace README.txt to README.md and update README.md

The "configuration" section of the readme should describe that the Range Input widget needs to be selected for a relevant facet, and the Range Input processor be selected, for this to work.

The help text in MR #5 does not correctly reflect this.

svendecabooter changed the visibility of the branch 3337791-replace-readme.txt-to to hidden.

Thanks for the MR. Committed now.

Drupal 9 is no longer officially supported, and OOP hooks only work for 10.1+ anyway

Sven Decabooter added a comment on drupal.org: Use PHP attributes instead of annotations

Sven Decabooter added a comment on drupal.org: Automated Drupal 11 compatibility fixes for tocbot

Sven Decabooter added a comment on drupal.org: Support OOP hooks

I could work on this if I find some time. Currently just reporting this, without intent to immediately provide some code.

svendecabooter created an issue. See original summary.

Problem/Motivation

Starting in Drupal 10.2.0, plugins should be defined with PHP attributes instead of annotations. When defining new plugin instances you should prefer PHP Attributes over annotations assuming the underlying plugin manager has been updated to support the use of attributes.

Proposed resolution

Allow PHP attributes for plugin definitions, as per https://www.drupal.org/docs/drupal-apis/plugin-api/attribute-based-plugins

Sven Decabooter added a comment on drupal.org: Clone nested inline blocks when translating

Sven Decabooter added a comment on drupal.org: Clone nested inline blocks when translating

borisson_ credited svendecabooter.

MR looks good. Still to be added: Setting minimum Drupal version to 10.2

MR introduces PHPCS / PHPStan issues, which would ideally be resolved before merging.

Gave some feedback on the MR

I think it would be better to ignore the PHPStan error about the internal class usage, by ignoring it through a phpstan.neon file in the project, rather than copying over the whole PHP class from core...

Although just ignoring it might give a false sense of security, since we are overriding an internal class, that might suddenly break without BC warnings. But that should probably be covered by test scenario's.

Randal added a comment on drupal.org: Support oop hooks

Problem/Motivation

Implement OOP hooks for better OOP & DI support, instead of having all hook logic in the module file.

Proposed resolution

Convert hook implementations to OOP hooks, with backwards compatibility. See https://www.drupal.org/node/3442349

Remaining tasks

- Define hooks that can be converted into OOP hooks - Create hook clas(ses) to logically bundle relevant hooks with their logic - Add backwards compatibility support

User interface changes

N/A

API changes

N/A

Data model changes

N/A

randalv created an issue. See original summary.

@svendecabooter the changes have been applied in the MR. Feel free to check it out, everything seems to work fine.

Changed minimum Drupal Core version to 10.1, PHP remains at >= 8.1.

randalv made their first commit to this issue’s fork.

I created a dev release