Een hart voor de Drupal Community

Merge request has been updated, since the blocking issue is now resolved. PHPCS pipeline is passing now.

svendecabooter made their first commit to this issue’s fork.

Sven Decabooter added a comment on drupal.org: Drupal Coding Standarad issues

I'm running MAMP on Mac OS X and I found this issue which helped me.

I'm adding mu solution here for future reference (if needed):

I was unable to send mails locally (and catch them with mailhog).

I got the following error:

An attempt to send an e-mail message failed, and the following error message was returned : Error creating transports: Unsupported sendmail command flags "/Applications/MAMP/Library/bin/mhsendmail --smtp-addr=0.0.0.0:1025"; must be one of "-bs" or "-t" but can include additional flags.

The solution was to add the following line in the php.ini file of the active php version:

; For Unix only.  You may supply arguments as well (default: "sendmail -t -i").
; http://php.net/sendmail-path
sendmail_path = "/Applications/MAMP/Library/bin/mhsendmail -t --smtp-addr=0.0.0.0:1025";

Thank you for the new release 🙏

Fons added a comment on drupal.org: JS code is executed multiple times.

I've tested the MR and everything works fine.

Problem/Motivation

When trying to change an existing media item, I get the error message "Non-reusable blocks must set an access dependency for access control."

This is for the drupal.be website - so might be related to i18n, although we have only set up 1 language so far.

This can be worked around by removing said block, and creating a new one with the new image, but that's a bit cumbersome.

Steps to reproduce

- Edit an existing page, e.g. Homepage. - Try to change the media item used, by providing a new one.

svendecabooter created an issue.

Problem/Motivation

For the drupal.be website I set up a homepage banner block with an image to the left. The image contains a rather dark background.

When checking the site on mobile, the hamburger menu was not visible, because it consists of black lines. I have resolved this by choosing another image for the homepage banner, but it took me a few week until I noticed. So preferably we can provide a fix for this, so that the hamburger menu is still visible with a dark background image, or alternatively, provide a warning to content editors to make sure they do not use such an image, as to not break the experience for mobile users.

Steps to reproduce

- Edit homepage - Edit "Homepage banner" block and upload an image with a dark background instead.

svendecabooter created an issue.

Sven Decabooter added a comment on drupal.org: Layout Builder translation issues

Sven Decabooter added a comment on drupal.org: Update to config split 2.x for patching capability

Sven Decabooter added a comment on drupal.org: Support language switcher and multilingual

bramdriesen credited svendecabooter.

Sven Decabooter added a comment on drupal.org: Code style cleanup

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

svendecabooter created an issue. See original summary.

Problem/Motivation

Use return types where relevant, etc...

svendecabooter created an issue. See original summary.

Thanks for the MR. Manually updated the fix for the new OOP hook implementations

Sven Decabooter added a comment on drupal.org: Use OOP hook implementations

Problem/Motivation

Use OOP hooks, as per [#3442349]

svendecabooter created an issue. See original summary.

Thanks - committed now.

This looks like a duplicate of #3347330: Modal Does not Close Automatically (possibly only on multilingual sites), caused by the absolute URL. Can you report back in that ticket if the problem still persists on the latest version of this module?

Sven Decabooter added a comment on drupal.org: Block translation don't open in modal with layout_builder_st

Did the addition of a dialog class in #3308949: Add a class to the dialog container help here in any way? Or would the patch by kpaxman still need to be applied to help resolve this issue?

This patch & MR no longer apply to the current 1.3.x state. I have also tested on a multilingual site (with paths instead of domains configured though), and cannot reproduce the issue. Can people who encountered this, retest with the latest version of this module, and report back if the problem still exists?

Can you check if this got resolved by the change in #3348594: Custom route to open in modal is restricted? That fix should also fix the issue with layout_builder_st