Een hart voor de Drupal Community

Thanks - committed!

Problem/Motivation

Fix cspell & phpcs warnings, as reported by Gitlab CI.

svendecabooter created an issue. See original summary.

Sven Decabooter added a comment on drupal.org: Add support for showing that attachments were added to the mail

Thanks for the fix, and sorry for the delay in committing.

Sven Decabooter added a comment on drupal.org: Automated Drupal 11 compatibility fixes for symfony_mailer_log

Sven Decabooter added a comment on drupal.org: Error when saving Log Settings

Thanks for the fix. Committed now.

Thanks for looking into this sarvjeetsingh. It hadn't occurred to me that this could be the source of the issue. Fix in MR resolves the issue for me.

Added MR that adds this functionality + a patch file for Composer-based patching workflows. Thanks for considering merging this functionality.

Problem/Motivation

I am using the core patch #3180702: Export block UUID with custom Layout Builder blocks to store a block UUID in config, to allow Layout Builder blocks to be added via default_content export / import functionality.

This does not work together with the logic in this module. The blocks do get translated via AI, but the translation is not correctly saved.

Steps to reproduce

Try this module with the patch mentioned above applied.

Proposed resolution

Some conditional logic could be added to make this work for sites that have this patch applied, while still working as expected for most sites that wouldn't have this patch applied.

svendecabooter created an issue. See original summary.

Problem/Motivation

I enable and configure the ai_translate module via a recipe. After recipe installation, the translation controller is not overridden, so not showing the "Translate using ..." link.

When explicitly saving the configuration form, it does work. Seems like this is triggered by \Drupal\ai_translate\Form\AiTranslateSettingsForm::submitForm. But upon recipe installation, this does not get triggered...

Steps to reproduce

Install the module via a recipe, and try to translate a content item.

svendecabooter created an issue. See original summary.

Merge request added. This probably also can be committed to 1.0.x and 1.2.x branch, but I made the MR against 1.1.x, since I'm actively working with that branch.

Problem/Motivation

Page at https://project.pages.drupalcode.org/ai/modules/ai_translate/ mentions 2. Navigate to /admin/config/ai/ai_translate, but the URL is /admin/config/ai/ai-translate instead.

svendecabooter created an issue. See original summary.

Added patch file for the current state of the MR, for composer based patching workflows.

I added a MR to add this functionality. Whether or not the Provider Configuration fieldset is open by default or not, is managed via config. The default setting for this config is to remain open, to keep backwards compatibility.

svendecabooter made their first commit to this issue’s fork.

EDIT: seems to be unrelated to this patch, because I'm getting the same errors when patch is not applied.

Tested with OpenAI, and getting the following errors:

Warning: Undefined array key "fids" in Drupal\media_library\Form\FileUploadForm->validateUploadElement() (line 212 of /var/www/html/web/core/modules/media_library/src/Form/FileUploadForm.php)

ypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in count() (line 212 of /var/www/html/web/core/modules/media_library/src/Form/FileUploadForm.php).

Haven't investigated the root cause yet...

All code review issues have been fixed, and extra explanation has been provided. Setting this to Needs Review.

Thanks for the bug report, MR and review! Merging now.

Sven Decabooter added a comment on drupal.org: sourceEditing plugin no longer gets enabled automatically in 1.1.x

Added a patch file, to be used in Composer-based patching workflows.

Sven Decabooter added a comment on drupal.org: sourceEditing plugin no longer gets enabled automatically in 1.1.x

svendecabooter created an issue. See original summary.

Problem/Motivation

Issue #3499702: AI CKEditor requires the Source CKEditor button added logic to automatically enable the CKEditor5 'sourceEditing' plugin, in the response text textarea, since this is needed for the Completion plugin to work.

However, in branch 1.1.x most of the logic is still there, except the flag to enable this functionality on the response_text text_format form element. This seems to be missing, probably because this is now handled in the generic AiCKEditorPluginBase class.

Steps to reproduce

- Use AI module 1.1.x - Enable the AI CKeditor module - Enable the Completion ("Generate with AI") plugin - Do NOT add the source code button to your CKEditor5 toolbar by default - Try using the Completion plugin in your CKEditor5-powered text area - this will fail (as described in #3499702: AI CKEditor requires the Source CKEditor button).

Proposed resolution

- Re-add the logic from #3499702: AI CKEditor requires the Source CKEditor button to active this for the Completion plugin.

Rebased the MR on current 11.x to resolve merge conflict.