Een hart voor de Drupal Community

Does this issue still exist on the latest version of the module?

Sven Decabooter added a comment on drupal.org: layout_builder_iframe_modal_link_alter no longer works when contextual is enabled.

Sven Decabooter added a comment on drupal.org: The website encountered an unexpected error. Try again later. TypeError: implode(): Argument #1 ($array) must be of type array, string given in implode() (line 74 of modules/contrib/layout_builder_iframe_modal/src/Form/LayoutBuilderIframeModalSettingsFor

That seems more like an issue of a bad workflow regarding config management... But the proposed fix is fairly straight forward, so will add it as an extra safeguard.

Sven Decabooter added a comment on drupal.org: The website encountered an unexpected error. Try again later. TypeError: implode(): Argument #1 ($array) must be of type array, string given in implode() (line 74 of modules/contrib/layout_builder_iframe_modal/src/Form/LayoutBuilderIframeModalSettingsFor

Sven Decabooter added a comment on drupal.org: Make compatible with 'Administer users by role' module

Improved the logic from #3451443: Add permission for resending emails to make it compatible with other modules, that provide a workaround for the broad 'administer users' permission. Now you can access the feature when you have 'administer users' permission, or the module-specific permission.

svendecabooter made their first commit to this issue’s fork.

Added the new permission, while keeping the existing access logic intact. You can now use this functionality if you are able to update user entities (current access logic), OR apply the action to user entities if you have the newly added permission granted.

I guess you would need to debug this via XDebug or something... Alternatively, you could switch to using the Drupal Symfony Mailer Plus module with an SMTP transport configured, and install Drupal Symfony Mailer Log module. This will create a log entry for each outgoing email, making it easier to debug if the mail is going out or not.

Sorry for not coming back to this. That seems like a useful feature to be added to an optional submodule, for users seeking that functionality. Or within the module itself as a configuration option (but disabled by default).

Sven Decabooter added a comment on drupal.org: Dependencies module missinge in info.yml

Looks good, thanks!

Sven Decabooter added a comment on drupal.org: Use PHP attributes instead of annotations

Weird, I can't seem to reproduce this (although I'm testing with Drupal 11.2 currently). Version 1.3.6 didn't introduce anything that should break this again, so it's probably due to core changes.

@nidhi27 yeah that was my rough idea... not sure if that's easily doable.

Brecht Ceyssens added a comment on drupal.org: Flushing image, when webp module is used, doesnt work correctly

Patch moves webp logic to a better place.

bceyssens created an issue. See original summary.

The combination of these 2 tickets causes issues:

• https://www.drupal.org/project/flush_single_image/issues/3187232
• https://www.drupal.org/project/flush_single_image/issues/3102639

When the webp image exists, it will only delete that one causing images but the be updated correcly. If you choose regeneration, the derivative is forced saved as the webp variation.

I tested this logic, both updating fields created in the 3.x version, and adding new fields. I have found no real issues with it. Seems like a good improvement to me.

Sven Decabooter added a comment on drupal.org: Code cleanup

svendecabooter created an issue. See original summary.

General code cleanup

Sven Decabooter added a comment on drupal.org: Add schema validation

Merging now.

OK those seem like 2 valid points to stick with the current approach. If the current logic would pose unexpected problems, we can still change the implementation later on.

Thanks for the clarification. Sounds like a good improvement to me.

Isn't this (partially) implemented in #3524435: Add token usage to streamed chat, or am I reading this incorrectly?

Sven Decabooter added a comment on drupal.org: Add a cleanup function