Een hart voor de Drupal Community

Thanks for the patch and rebase. Committed now.

Thanks for the patch. Committed now.

Thanks for the patch. Committed now.

The patch in attachment fixed the issue for me.

f0ns created an issue. See original summary.

Problem/Motivation

When using this module I noticed there are console.log notices:

I think the code in highlight-custom.js can be altered to fix this when once is introduced in this logic.

Brecht Ceyssens added a comment on drupal.org: Attach library to block

bceyssens created an issue. See original summary.

The library should not get loaded on every page, only when the block is used.

This patch fixed this behavior in the settings form for me.

f0ns created an issue. See original summary.

Problem/Motivation

The default value of the Copy Button Background Color field is not set properly in the configuration form (it looks at copy bg transparent) which gives weird behavior / makes it impossible to set your own value.

Hi julianriemersma,

Thanks for reporting the issue! I've finally gotten around to provide a fix, I had to fix it a bit differently because removing 'authenticated' from disallowed roles was creating some other issues.

I added a new release.

Sven Decabooter added a comment on drupal.org: Support language switcher and multilingual

Part of this is tackled in #3509600: Layout Builder translation issues - to fix the layout_builder_at issues currently in the project.

Sven Decabooter added a comment on drupal.org: Update to config split 2.x for patching capability

Sven Decabooter added a comment on drupal.org: Layout Builder translation issues

Problem/Motivation

Creating translations for a Component page do not seem to work: - Blocks from the original translations are not copied over - There are some issues with stale data

Proposed resolution

- Configure Layout field of Component page form display correctly - Update to latest layout_builder_at release, which fixes the other issues

svendecabooter created an issue. See original summary.

Thanks for the MR & reviews. Committed now.

Sven Decabooter added a comment on drupal.org: Removing and adding translations causes stale data to be shown when editing

I can confirm this issue, and the added patch fixes it. Committed now.

Sven Decabooter added a comment on drupal.org: Removing and adding translations causes stale data to be shown when editing

Problem/Motivation

Currently the project depends on config_split 1.x, with a "develop" split configured. The Belgian (and other) websites are using config split in order to split of language-specific configuration (e.g. enable FR language for the .be website, which should not happen in the general project).

I propose to update the config_split module to its version 2.x as soon as possible, because that introduces the concept of patching. Rather than splitting a whole config YML file, config_split only puts the changes in the split directory.

Steps to reproduce

The default language.negotiation.yml looks like this:

session:
  parameter: language
url:
  source: path_prefix
  prefixes:
    en: en
    '': null
  domains:
    en: ''
selected_langcode: site_default

When using config_split 1.x, we split the whole file. If later the "session" or "selected_langcode" property would change in the default config, it will not propagate to the split off configurations.

Proposed resolution

Use config_split 2.x, so the above configuration would be stored in config/drupal_be split folder as follows:

adding:
  url:
    prefixes:
      nl: nl
      fr: fr
      de: de
    domains:
      nl: ''
      fr: ''
      de: ''
removing:
  url:
    prefixes:
      '': null

This alters only the prefixes content, nothing else.

If we decide to let all spin-off sites use config_split, it will be a lot more maintainable this way.

Remaining tasks

- Create MR to update to config_split 2.x + update existing splits

Problem/Motivation

PHPCS reports various issues with this module.

Proposed resolution

- Add Gitlab CI to automate code quality checks - Fix reported issues

Problem/Motivation

When setting up the token with `without-some-parameters` or `with-some-parameters` options, we are getting an error on non-existing pages, which should just render a 404 page instead:

TypeError: array_intersect_key(): Argument #1 ($array) must be of type array, null given in array_intersect_key() (line 104 of modules/contrib/token_url_plus/token_url_plus.module).

Steps to reproduce

- Install this module + Metatag (for example) - Set a global metatag (e.g. canonical URL) that uses the following token: "[current-page:url-with-query:with-some-parameters:page]" - Go to the path "/path-does-not-exist"

Proposed resolution

- Make sure the $query variable is an array, before performing array-operations on it.

Bram Goffings added a comment on drupal.org: Automated Drupal 10 compatibility fixes

Bram Goffings added a comment on drupal.org: Fix DomainMenuAccessControlHandler::checkAccess

Patch #2 works here as well.

@berdir is it possible to roll a new release?