Een hart voor de Drupal Community

Sven Decabooter added a comment on drupal.org: Support image_widget_crop 3.0

Support image_widget_crop 3.0.x branch: https://www.drupal.org/project/image_widget_crop/releases/3.0.x-dev

svendecabooter created an issue. See original summary.

Good to see progress being made here, and thanks to everyone being candidate to step up for this role!

I'd like to cast a vote for: - Joris Vercammen (borisson_) - Marine Gandy (Mupsi)

Hi,

This module currently remains unmaintained and unsupported, while I feel like this module absolutely has its use in modern Drupal websites. From translated paths for views to custom controller path aliases, there's a number of cases where this is useful.

On my profile you can see a few modules I actively maintain, I also attempt to create and fix issues I encounter in other modules.

So, in short, I'd like to "revive" this module and release new versions and keep it up-to-date with the latest versions of Drupal.

Feel free to contact me for further questions!

- https://www.drupal.org/project/fixed_path_alias

randalv created an issue. See original summary.

Drupal 9 is no longer supported, so we should drop support for both Drupal 9 and PHP7, not the other way around.

kraut credited svendecabooter.

esmoves credited svendecabooter.

New tag has been released. Thanks again!

Hi @andybroomfield,

Good catch! The class name was altered at the last moment before merge, seems I forgot to alter the service name. Thank you.

I'll merge and release a new version.

randalv made their first commit to this issue’s fork.

Seems logical, I've added the hooks_converted parameter.

Since the other threads are resolved, I'll merge into 1.2.x

Sven Decabooter added a comment on drupal.org: Support OOP hooks

Sven Decabooter added a comment on drupal.org: Support OOP hooks

MR looks good to me. Maybe we also need to add the 'hooks_converted' parameter for performance improvement: https://www.drupal.org/node/3490771

Seems like core is mostly putting all hooks together in a Hook\[MODULENAME]Hooks.php file, but I agree splitting up in logical chunks / files makes sense.

Processed the feedback.

I was also debating whether the Help and Cron hooks could be merged into a "Core.php" file since they're both small hooks, but I just kept them in their own file. Figured it's better to keep things as split up as possible, which is the whole point of moving away from one gigantic .module file to OOP hooks :)

- Hook help still needs to be added as OOP hook - All hooks need to be marked as converted, as per https://www.drupal.org/node/3490771

Sven Decabooter added a comment on drupal.org: Improve performance by preventing unnecessary scanning of procedural hooks

Problem/Motivation

See https://www.drupal.org/node/3490771

svendecabooter created an issue. See original summary.

Reverted, because module still contains a preprocess procedural hook.

Sven Decabooter added a comment on drupal.org: Improve performance by preventing unnecessary scanning of procedural hooks

Problem/Motivation

See https://www.drupal.org/node/3490771

svendecabooter created an issue. See original summary.

Sven Decabooter added a comment on drupal.org: Improve performance by preventing unnecessary scanning of procedural hooks

Problem/Motivation

See https://www.drupal.org/node/3490771

svendecabooter created an issue. See original summary.

Thanks for the MR and improvements!