Een hart voor de Drupal Community

borisson_ credited svendecabooter.

svendecabooter made their first commit to this issue’s fork.

Added MR + uploaded patch file for Composer-based workflows.

Problem/Motivation

Drupal core provides an AccountSwitcher service, to quickly change the currently logged in user. For example, Symfony Mailer uses this service to switch to the appropriate account that needs to receive the email that the module is preparing.

We ran into conflicts here in some scenarios. For example: An admin is viewing the site in Dutch, and performs an action that triggers a mail to be sent to specific other user. That other user's preferred language is French, and is saved as such in their profile. When Symfony Mailer temporarily switches accounts to the French user, the LanguageNegotiationUserAccountSaver kicks in, finds the current language as Dutch (because the admin is viewing the site in Dutch), and saves the preferred language of the French user to Dutch.

Steps to reproduce

See example above.

Proposed resolution

AccountSwitcher changes a flag in the WriteSafeSessionHandler service. Use this to check if user language can be updated or not.

Remaining tasks

Create MR with fix

svendecabooter created an issue. See original summary.

- Merged 3.x into the MR - Changed the update hook so it lands at the end (I figure since this is new functionality, logically we shouldn't let it run before newer update hooks) - Added form states so the client secret is only visible and required if PKCE mode = off - Added a deprecation warning explaining that not supplying the "$session"-parameter is deprecated, but doesn't break anything if that is the case

The MR applies again and seems to work functionally as it did before, issues risen in #43 and #44 should be solved with this too.

randalv made their first commit to this issue’s fork.

bramdriesen credited svendecabooter.

I have added test coverage for this. Not sure if this belongs in LoaderLanguageTest specifically, but it had all the setup logic already available, so seemed like the easiest place to add this test.

Sven Decabooter added a comment on drupal.org: Scroll_smooth_offset is not working

Sven Decabooter added a comment on drupal.org: Scroll_smooth_offset is not working

Sven Decabooter added a comment on drupal.org: Scroll_smooth_offset is not working

Problem/Motivation

The module currently doesn't have a config schema definition, as /config/schema/tocbot.schema.yml is missing.

Proposed resolution

Add it.

Remaining tasks

Create a MR

svendecabooter created an issue.

svendecabooter made their first commit to this issue’s fork.

bramdriesen credited svendecabooter.

Sven Decabooter added a comment on drupal.org: Add Gitlab CI integration + fix coding standards issues

Sven Decabooter added a comment on drupal.org: Fix the issues reported by phpcs

Logic has evolved too much to fix the MR in this issue. Closing this one in favor of #3513921: Add Gitlab CI integration + fix coding standards issues, while giving credit to contributors in this issue.

Sven Decabooter added a comment on drupal.org: Add Gitlab CI integration + fix coding standards issues

Problem/Motivation

Add height / width attributes for Media entities of type video

svendecabooter created an issue.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

svendecabooter created an issue. See original summary.

svendecabooter made their first commit to this issue’s fork.

Sven Decabooter added a comment on drupal.org: Missing attributes for images

Sven Decabooter added a comment on drupal.org: Add lazy loading option for image formatter

Sven Decabooter added a comment on drupal.org: Add lazy loading option for image formatter

Sven Decabooter added a comment on drupal.org: The website encountered an unexpected error. Try again later. TypeError: implode(): Argument #1 ($array) must be of type array, string given in implode() (line 74 of modules/contrib/layout_builder_iframe_modal/src/Form/LayoutBuilderIframeModalSettingsFor

Did you update from a previous version? If so, did you run update.php or "drush updb"?